Skip to content

feat(cli): add post-ready test command hooks - #202

Merged
zackees merged 1 commit into
mainfrom
feat/test-cmd
Jul 14, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/test-cmd

Conversation

@zackees

@zackees zackees commented Jul 14, 2026 •

Copy link
Copy Markdown
Member

Summary

  • add repeatable --test-cmd hooks after first rendered-frame readiness
  • run trusted shell commands sequentially with contained process groups, piped output, terminal/log markers, and shared cancellation
  • wait for both viewer and command completion while preserving existing exit-code precedence
  • document shell, working-directory, output, trust, and timeout behavior

Closes #200

Tests

  • bash lint (pass)
  • soldr cargo test -p fastled-cli --no-default-features --lib (219/219 pass)
  • soldr cargo test -p fastled-cli --no-default-features issue_200 --lib (3/3 pass)
  • soldr rustfmt --edition 2021 ...
  • git diff --check

The workspace contains only fastled-cli; the full package library suite is the workspace unit-test coverage. A repeated soldr cargo test --workspace run entered the existing Windows contained-process test latency and was stopped after no progress; focused and full package tests pass.

@zackees
zackees merged commit 2465652 into main Jul 14, 2026
12 of 22 checks passed
@zackees
zackees deleted the feat/test-cmd branch July 14, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(cli): add --test-cmd post-ready command hook

1 participant